Skip to content

Common metadata updates #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m-mohr merged 11 commits into from
Jan 17, 2020
Merged

Common metadata updates #712

m-mohr merged 11 commits into from
Jan 17, 2020

Conversation

@anayeaye
Copy link
Contributor

@anayeaye anayeaye commented Jan 8, 2020 •
edited
Loading

Related Issue(s): #
N/A

Proposed Changes:

  1. Corrects item jsonschema to evaluate all common metadata schemas
  2. Item-spec and common-metadata documentation updated with more information about common metadata fields.

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files. N/A

anayeaye
anayeaye commented Jan 8, 2020
View reviewed changes
@anayeaye anayeaye requested review from joshfix and m-mohr January 8, 2020 23:02
m-mohr
m-mohr reviewed Jan 8, 2020
View reviewed changes
@m-mohr
Copy link
Collaborator

m-mohr commented Jan 8, 2020

Wondering whether we should move title to the Common metadata?

@joshfix
Copy link
Contributor

joshfix commented Jan 9, 2020

Wondering whether we should move title to the Common metadata?

Hmm I think that's a good idea.

@m-mohr m-mohr mentioned this pull request Jan 10, 2020
Closed
m-mohr
m-mohr requested changes Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some minor things to change.

@m-mohr m-mohr merged commit 0fa2bb6 into radiantearth:dev Jan 17, 2020
@cholmes cholmes added this to the 0.9.0 milestone Jan 22, 2020
@cholmes cholmes mentioned this pull request Jan 22, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cholmes cholmes cholmes approved these changes

@m-mohr m-mohr m-mohr approved these changes

+1 more reviewer

@joshfix joshfix joshfix approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@anayeaye @m-mohr @joshfix @cholmes