Skip to content

Pagination documentation update #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cholmes merged 7 commits into from
Jan 21, 2020
Merged

Pagination documentation update #717

cholmes merged 7 commits into from
Jan 21, 2020

Conversation

@joshfix
Copy link
Contributor

@joshfix joshfix commented Jan 15, 2020

Related Issue(s): #716

Proposed Changes:

  1. Documentation updates to clarify how to implement new pagination mechanism for POST requests

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

@joshfix joshfix added stac-api minor a relatively small change to the spec labels Jan 15, 2020
@joshfix joshfix added this to the 0.9.0 milestone Jan 15, 2020
@joshfix joshfix requested review from a user, cholmes, m-mohr and matthewhanson January 15, 2020 17:47
@joshfix joshfix changed the title Pagination Pagination documentation update Jan 15, 2020
m-mohr
m-mohr reviewed Jan 17, 2020
View reviewed changes
joshfix and others added 3 commits January 17, 2020 11:55
@joshfix @m-mohr
Update api-spec/api-spec.md
f64e182 
Allow for any method in link's method field.

Co-Authored-By: Matthias Mohr <[email protected]>
@joshfix @m-mohr
Update api-spec/api-spec.md
2d3bda9 
Add default value for merge field in link object.

Co-Authored-By: Matthias Mohr <[email protected]>
@joshfix
updated examples
594b4c2
@joshfix joshfix requested a review from m-mohr January 17, 2020 17:34
m-mohr
m-mohr approved these changes Jan 20, 2020
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cholmes cholmes merged commit c1468d7 into radiantearth:dev Jan 21, 2020
@cholmes cholmes mentioned this pull request Jan 22, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cholmes cholmes cholmes approved these changes

@m-mohr m-mohr m-mohr approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

Assignees

No one assigned

Labels

minor a relatively small change to the spec

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@joshfix @cholmes @m-mohr @matthewhanson