Skip to content

Conversation

@jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Jan 17, 2020

Related Issue(s): #

none

Proposed Changes:

  1. Respond with as specific a response as possible when we know what went wrong with an item update in api transactions extension PUT. BadRequest and NotFound don't tell the user that they should refresh the object and try again, while a PreconditionFailed for a request with an If-Match header is extremely clear

PR Checklist:

  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • API only: I have run npm run generate-all to update the generated OpenAPI files.

@jisantuc jisantuc changed the title Response with PreconditionFailed when If-Match header invalid Respond with PreconditionFailed when If-Match header invalid Jan 17, 2020
@m-mohr m-mohr added this to the 0.9.0 milestone Jan 21, 2020
@cholmes cholmes changed the base branch from master to dev January 21, 2020 17:49
@cholmes cholmes merged commit 2c42c65 into dev Jan 21, 2020
@cholmes
Copy link
Contributor

cholmes commented Jan 21, 2020

Thanks for the contribution! Will be in 0.9.0-RC2, as discussed in the call, since it is a minor improvement and we're going to do the rc2 regardless.

@cholmes cholmes mentioned this pull request Jan 22, 2020
3 tasks
@m-mohr m-mohr deleted the feature/js/include-appropriate-http-response branch March 31, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants