Skip to content
This repository was archived by the owner on Feb 28, 2021. It is now read-only.

Conversation

@geigerzaehler
Copy link

This update requires the following changes

  • In the client we match all invalid transaction statuses with one pattern.
  • The account nonce is now retrieved via the frame_system::Account storage.
  • The frame_system::Trait::Event associated type has now a type bound that is generic over Self. This requires us to explicitly state some type bounds.

@geigerzaehler
Copy link
Author

The builds fail because we seem to generate invalid transactions for the end-to-end tests. This looks like quite the issue. We need to find out why the transaction is invalid. Unfortunately the RPC apis don’t provide enough error information I believe. We might need to have the node log information to determine the error. It’s most likely that the transactions are invalid because calling <UncheckedExtrinsic as Checkable>::check() fails. The place too look would be client/src/transaction.rs.

@NunoAlexandre
Copy link
Contributor

any luck, @CodeSandwich?

@CodeSandwich
Copy link
Contributor

We were able to find out that it's the node that is rejecting the transactions, it's sending Invalid message to the client. We've pinned down the exact commit in Substrate that introduces this behavior: paritytech/substrate@0c8e059. Now I'm trying to find out what exactly in this commit is offensive to create a fix or workaround.

@CodeSandwich
Copy link
Contributor

CodeSandwich commented Mar 16, 2020

The upgrade is finally fixed 🎉

DO NOT MERGE
It depends on a commit in a feature branch, please wait for it getting merged and upgrade to newest master to avoid depending on a squashed-away WIP commit: paritytech/substrate#5227

@CodeSandwich CodeSandwich force-pushed the update-substrate branch 2 times, most recently from 8de5689 to d3ad1bf Compare March 18, 2020 10:25
@CodeSandwich
Copy link
Contributor

Ready to be merged!

@CodeSandwich CodeSandwich force-pushed the update-substrate branch 2 times, most recently from e5b06ac to d6bf527 Compare March 18, 2020 12:58
@CodeSandwich CodeSandwich force-pushed the update-substrate branch 2 times, most recently from 11a122e to bc0375c Compare March 18, 2020 14:45
Copy link
Author

@geigerzaehler geigerzaehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeSandwich CodeSandwich self-requested a review March 18, 2020 16:06
@CodeSandwich CodeSandwich merged commit 63390ae into master Mar 18, 2020
@CodeSandwich CodeSandwich deleted the update-substrate branch March 18, 2020 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants