Skip to content

Introduce a 'tailwindcss:upgrade' task #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flavorjones merged 3 commits into from
Jan 23, 2025
Merged

Introduce a 'tailwindcss:upgrade' task #466

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e507b0e
prefactor: rename user_journey_test to user_install_test
flavorjones Jan 23, 2025
25010f3
Introduce a 'tailwindcss:upgrade' task
flavorjones Jan 23, 2025
fef615c
If present, move config/postcss.config.js to root
flavorjones Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
prefactor: rename user_journey_test to user_install_test
  • Loading branch information
@flavorjones
flavorjones committed Jan 23, 2025
commit e507b0ee1b89f90b31f5d9f0b7cfd929c540d5ff
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
- name: Run tests
run: bin/test

user-journey:
user-install:
strategy:
fail-fast: false
matrix:
Expand All @@ -44,5 +44,5 @@ jobs:
with:
ruby-version: "3.4"
bundler: latest
- run: test/integration/user_journey_test.sh
- run: test/integration/user_install_test.sh
shell: bash
6 changes: 3 additions & 3 deletions .github/workflows/upstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ jobs:
- name: Run tests
run: bin/test

user-journey:
name: "user-journey (rails ${{ matrix.ref }})"
user-install:
name: "user-install (rails ${{ matrix.ref }})"
runs-on: ${{matrix.plat}}-latest
strategy:
fail-fast: false
Expand All @@ -50,5 +50,5 @@ jobs:
with:
ruby-version: "3.3"
bundler: latest
- run: test/integration/user_journey_test.sh
- run: test/integration/user_install_test.sh
shell: bash
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ This doc is a brief introduction on modifying and maintaining this gem.

The unit tests are run with `bundle exec rake test`

There is an additional integration test which runs in CI, `test/integration/user_journey_test.sh` which you may also want to run.
There is an additional integration test which runs in CI, `test/integration/user_install_test.sh` which you may also want to run.


### Testing in a Rails app
Expand Down
4 changes: 2 additions & 2 deletions test/integration/user_journey_test.sh → test/integration/user_install_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ pushd "My Workspace"

# create a rails app
bundle exec rails -v
bundle exec rails new test-app --skip-bundle
pushd test-app
bundle exec rails new test-install --skip-bundle
pushd test-install

# make sure to use the same version of rails (e.g., install from git source if necessary)
bundle remove rails --skip-install
Expand Down