chore: update documentation and enhance monitor group functionality, … - #741
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses #694 by making Group Monitor member selection scalable for large installations, introducing a reusable searchable monitor picker (with bulk-add) and updating related documentation/domain guidance.
Changes:
- Replaces the in-page eligible-monitor list UI in the Group Monitor editor with a searchable
MonitorPicker(including “Add all N matching” bulk add). - Enhances selected-member UX (avatars, weight input per member, remove-from-group button, and “inactive” indicator for ineligible members).
- Adds agent/domain documentation, an ADR for explicit group membership, and a repo-level
CONTEXT.mdglossary.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/(manage)/manage/app/monitors/[tag]/types/monitor-group.svelte | Integrates searchable picker + improves selected-member controls (weights/order/remove/stale indicator). |
| src/lib/components/MonitorPicker.svelte | New reusable searchable popover-based monitor picker with optional bulk-add. |
| docs/agents/triage-labels.md | Documents mapping from canonical triage roles to repo labels. |
| docs/agents/issue-tracker.md | Documents GitHub Issues conventions and gh CLI usage for agents. |
| docs/agents/domain.md | Documents how agents should use CONTEXT.md and ADRs as domain references. |
| docs/adr/0001-explicit-group-membership.md | ADR capturing decision to keep group membership explicit (not wildcard rules). |
| CONTEXT.md | Adds glossary for key monitoring concepts and terminology constraints. |
| CLAUDE.md | Links to new agent docs and clarifies repo conventions for agents. |
Comment on lines
+262
to
+266
| <Badge | ||
| variant="outline" | ||
| class="text-muted-foreground shrink-0 text-[10px]" | ||
| title="Not currently checked; excluded from group score" | ||
| > |
Comment on lines
+30
to
+31
| **Stale Member**: | ||
| A Member whose monitor is no longer an Eligible Monitor (paused or deleted after being added). It remains a Member until explicitly removed, but is excluded from the group score. |
Comment on lines
303
to
306
| class="h-7 w-7" | ||
| disabled={index === formData.monitors.length - 1} | ||
| onclick={() => moveMonitorDown(index)} | ||
| > |
Comment on lines
+312
to
+315
| class="hover:text-destructive h-7 w-7" | ||
| title="Remove from group" | ||
| onclick={() => removeMonitor(m.tag)} | ||
| > |
Comment on lines
+21
to
+24
| ├── docs/adr/ | ||
| │ ├── 0001-event-sourced-orders.md | ||
| │ └── 0002-postgres-for-write-model.md | ||
| └── src/ |
Comment on lines
+35
to
+37
| If your output contradicts an existing ADR, surface it explicitly rather than silently overriding: | ||
|
|
||
| > _Contradicts ADR-0007 (event-sourced orders) — but worth reopening because…_ |
Comment on lines
291
to
293
| <Button | ||
| variant="ghost" | ||
| size="icon" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…fixes #694