Rerun diagnostics when entering the diagnostics tab. #2974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Promislow <[email protected]>
mook-as
requested changes
Sep 22, 2022
Contributor
mook-as
left a comment
mook-as
left a comment
There was a problem hiding this comment.
Err, that seems like totally the wrong place? Please have pages/Diagnostics.vue dispatch a diagnostics/runDiagnostics in mounted() instead?
Contributor
Author
|
This isn't what we want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2972
I did see the connectivity status getting updated on tab switch, but didn't see updates for either
docker-plugin symlink or the kubectl context check. This change updates everything, when it's needed.
Note that if there has been a change in the # of diagnostics since the diagnostics panel was last shown,
the badge # in the Diagnostics tab doesn't get updated until the list in the panel is updated.
Signed-off-by: Eric Promislow [email protected]