Travis tests for Windows and fix for failing test #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also adds an additional (passing) test for checking the destroy method works on Windows (it does) - I've been doing some debugging around close functions and cleanup on WIndows. |
|
can we merge this in? |
|
Fixed in master a while ago, but added the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cross-platform travis tests for osx and Windows to check for cross-platform filesystem peculiarities.
On Windows there is a breaking test for trying to create raf for a directory. On Linux and Mac
fs.open()on a directory returns an error, but on Windows it returns a file descriptor (https://nodejs.org/api/fs.html#fs_file_system_flags).This PR fixes the breaking test by adding an additional check on open to check a
fdis not a directory.