Fix const qualifier when using host_span<bitmask_type const*>
#11220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
bug
davidwendt
approved these changes
Jul 7, 2022
vyasr
approved these changes
Jul 8, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11220 +/- ##
===============================================
Coverage ? 86.30%
===============================================
Files ? 144
Lines ? 22698
Branches ? 0
===============================================
Hits ? 19589
Misses ? 3109
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
Author
|
@gpucibot merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
This PR add Java binding for the set-like operations: * `lists::have_overlap` * `lists::intersect_distinct` * `lists::union_distinct` * `lists::difference_distinct` Depends on: * #11043 * #11220 New Java APIs start here: https://github.com/rapidsai/cudf/pull/11143/files#diff-50ba2711690aca8e4f28d7b491373a4dd76443127c8b452a77b6c1fe2388d9e3R3545 Authors: - Nghia Truong (https://github.com/ttnghia) Approvers: - Robert (Bobby) Evans (https://github.com/revans2) URL: #11143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are several places in cudf that use
host_spanof a pointer type, such ashost_span<bitmask_type const*>inbitmask_and(). Ahost_span<bitmask_type const*>must be constructed from a non-const object, such as a non-conststd::vector. If we have a const vector then we cannot use it to construct the requiredhost_spanunless we strip const qualifier out of the const vector.This PR fixes that issue, changing from
host_span<bitmask_type const*>tohost_span<bitmask_type const* const>which allows to construct thehost_spanfrom both const and non-const container objects.