Skip to content

Update ContactFactory.php #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update ContactFactory.php #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update ContactFactory.php 
this updates the request to match the new structure of the title specified in https://developers.google.com/contacts/v3/
  • Loading branch information
@basselhossam
basselhossam authored Dec 2, 2018
commit f2af28d94c7a260d52e8b80c79f3021eebb2db16
5 changes: 3 additions & 2 deletions factories/ContactFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,9 @@ public static function create($name, $phoneNumber, $emailAddress, $note, $custom
$entry->setAttributeNS('http://www.w3.org/2000/xmlns/', 'xmlns:gd', 'http://schemas.google.com/g/2005');
$doc->appendChild($entry);

$title = $doc->createElement('title', $name);
$entry->appendChild($title);
$nameEntry = $doc->createElement('gd:name');
$nameEntry->appendChild($doc->createElement('gd:givenName', $name));
$entry->appendChild($nameEntry);

$email = $doc->createElement('gd:email');
$email->setAttribute('rel', 'http://schemas.google.com/g/2005#work');
Expand Down