Added Ethernet example(W5500 of WIZnet product) using SPI #98

irinakim12 · 2021-04-05T15:06:29Z

aallan · 2021-04-06T09:24:05Z

This looks good. We'll just have to grab a module and confirm that it's working and then we'll merge it in. This will probably get allocated to an intern over the summer, as we're going to be adding a lot of example code for various breakouts.

lurch · 2021-04-06T13:59:38Z

.gitignore

 .DS_Store
 *.pdf
+spi/w5500_spi/mpu9250_spi.fzz
+spi/w5500_spi/mpu9250_spi_bb.png


No need to add these to .gitignore, just delete them from your local directory 😃

I deleted the .gitignore on my local.

You've also (accidentally?) deleted it from this repo too, which you don't want to do.

lurch · 2021-04-06T14:01:57Z

spi/w5500_spi/w5500_spi.c

+#include "loopback.h"
+
+
+/* Example code to talk to a wiznet MEMS accelerometer and gyroscope.


lurch · 2021-04-06T14:02:37Z

spi/w5500_spi/w5500_spi.c

+   GPIO 3 (pin 5) MOSI/spi0_tx -> SDA on wiznet board
+   GPIO 4 (pin 6) MISO/spi0_rx-> ADO on wiznet board
+   GPIO 5 (pin 7) Chip select -> NCS on wiznet board
+   GPIO 6 (pin 9) SCK/spi0_sclk -> SCL on wiznet board


You seem to have spi0_sclk mentioned twice?

lurch · 2021-04-06T14:03:55Z

spi/w5500_spi/w5500_spi.c

+        return rx;
+
+    }
+    static void wiznet_write(uint8_t reg){


Please fix indentation

I fix indentation

spi/w5500_spi/README.adoc

lurch · 2021-04-07T11:19:16Z

spi/w5500_spi/loopback.c

+#endif
+			setSn_IR(sn,Sn_IR_CON);
+         }
+		 if((size = getSn_RX_RSR(sn)) > 0) // Don't need to check SOCKERR_BUSY because it doesn't not occur.


weird indentation

I fixed indentation. Check the one more time, please

lurch · 2021-04-07T11:19:32Z

spi/w5500_spi/loopback.c

+         //////////////////////////////////////////////////////////////////////////////////////////////
+         // Data Transaction Parts; Handle the [data receive and send] process
+         //////////////////////////////////////////////////////////////////////////////////////////////
+		 if((size = getSn_RX_RSR(sn)) > 0) // Sn_RX_RSR: Socket n Received Size Register, Receiving data length


weird indentation

I fixed indentation. Check the one more time, please

The indentation still seems a bit all over the place, but I think that might be because you're mixing tabs and spaces? 🤷

lurch · 2021-04-07T11:20:38Z

spi/w5500_spi/w5500_spi.c

+    // first, then subsequently read from the device. The register is auto incrementing
+    // so we don't need to keep sending the register we want, just the first.
+    uint8_t rx = 0, tx = 0xFF;
+        spi_read_blocking(SPI_PORT, &tx,  &rx, 1);


weird indentation

I fixed indentation. Check the one more time, please

lurch · 2021-04-20T06:56:58Z

spi/w5500_spi/README.adoc

+
+[NOTE]
+======
+This is a very basic example, and it send and receive data from the WIZ850io(W5500).After you get off the communication command(S"n"_CR) on the WIZ850io, make sure the communicationcommand is clear."n" is socket number.


Missing space in "communicationcommand"

Sorry, I fixed this line

Is it going on? Is it stopped?

See Alasdair's comment above: "This will probably get allocated to an intern over the summer, as we're going to be adding a lot of example code for various breakouts."

aallan · 2021-06-25T13:28:25Z

~~@matiasilva I don't think the hardware for this is on your desk yet. But when it arrives can you take a look at this PR?~~

aallan · 2021-07-01T08:24:14Z

@matiasilva We're also getting a couple of these boards, https://dokkodai.tistory.com/198, also based on the W5500, sent to us at the office. Hopefully the code should work on both, if not we probably have to generalise it before merging the PR.

aallan · 2021-07-20T08:54:52Z

Passed to @aayushijhaveri.

aayushijhaveri · 2021-07-20T10:58:41Z

Just tried running the code on the W5500 board from https://dokkodai.tistory.com/198 and it looks like it is working fine. It's printing out the Mac address, IP address etc.

aallan · 2021-07-20T14:42:16Z

Needs to be redrawn using Fritzing to match other diagrams,

there is a Wiz8250io part in the current Fritizing package AFAIK.

aallan

Extensive changes needed.

aallan · 2021-07-20T14:45:21Z

spi/w5500_spi/README.adoc

@@ -0,0 +1,59 @@
+= Attaching a W5500 via SPI
+
+This example code shows how to interface the Raspberry Pi Pico to the WIZ850io(W5500) board. The particular device used can be interfaced via SPI, we are using SPI, and interfacing at 3.3v.


Needs to mention the alternative board that we've now tested with, and any alternative arrangements needed, e.g. wiring etc?

aallan · 2021-07-20T14:45:38Z

spi/w5500_spi/README.adoc

+[NOTE]
+======
+This is a very basic example, and it send and receive data from the WIZ850io(W5500).After you get off the communication command(S"n"_CR) on the WIZ850io, make sure the communication command is clear."n" is socket number.
+It is also use the polling approach in the example.


Needs reworded.

aallan · 2021-07-20T14:46:14Z

spi/w5500_spi/README.adoc

+   * 3.3v (pin 36) -> VCC on IZ850io(W5500) board
+   * GND (pin 38)  -> GND on IZ850io(W5500) board
+
+The example here uses SPI port 0. Power is supplied from the 3.3V pin.


Needs reworded using standard language.

aallan · 2021-07-20T14:46:36Z

spi/w5500_spi/README.adoc

+
+[NOTE]
+======
+There are many different manufacturers who sell boards with the WIZ850io(W5500). Whilst they all appear slightly different, they all have, at least, the same 6 pins required to power and communicate. When wiring up a board that is different to the one in the diagram, ensure you connect up as described in the previous paragraph.


Repetitive wording.

aallan · 2021-07-20T14:48:03Z

spi/w5500_spi/README.adoc

+| *Item* | *Quantity* | Details
+| Breadboard | 1 | generic part
+| Raspberry Pi Pico | 1 | http://raspberrypi.org/
+| WIZ850io(W5500) board| 1 | https://eshop.wiznet.io/shop/module/wiz850io/


Need to reference alternatives. It's essentially a generic part.

aallan · 2021-07-20T14:51:15Z

spi/w5500_spi/socket.c

+//! \version 1.0.3
+//! \date 2013/10/21
+//! \par  Revision history
+//!       <2015/02/05> Notice


This is a frozen version. Instead of inserting this static version should be use the external library directly?

aallan · 2021-07-20T14:51:59Z

spi/w5500_spi/socket.c

+//!     * Redistributions in binary form must reproduce the above copyright
+//! notice, this list of conditions and the following disclaimer in the
+//! documentation and/or other materials provided with the distribution. 
+//!     * Neither the name of the <ORGANIZATION> nor the names of its 


Broken version of BSD 3 clause. Needs fixing if we're including the code in the repo.

aallan · 2021-07-20T14:53:03Z

spi/w5500_spi/w5500.c

+//! \version 1.0.2
+//! \date 2013/10/21
+//! \par  Revision history
+//!       <2015/02/05> Notice


I'm tempted to say that we should not include this code in the example, instead provide instructions to pull it from its own repo into a preconfigred place. Including it in this fashion seems unwise.

aallan · 2021-07-20T14:53:18Z

spi/w5500_spi/w5500.c

+		WIZCHIP.IF.SPI._write_byte((AddrSel & 0x0000FF00) >>  8);
+		WIZCHIP.IF.SPI._write_byte((AddrSel & 0x000000FF) >>  0);
+   }
+   else																// burst operation


Weird comments?

aallan · 2021-07-20T14:53:49Z

spi/w5500_spi/w5500.h

+//! \author MidnightCow
+//! \copyright
+//!
+//! Copyright (c)  2013, WIZnet Co., LTD.


Same again for this file.

aallan · 2021-07-28T09:14:24Z

So @aayushijhaveri has picked up this PR and done some more work on it. So closing this PR in favour of #147. We'll talk about W5500 example support over there. Many thanks!

irinakim12 and others added 8 commits April 6, 2021 00:04

Added Ethernet example(W5500 of WIZnet product) using SPI

f1c7e5b

Update README.adoc

8c2681b

Update README.adoc

b67ac4f

connetct W5500+raspberrypi pico

4c11263

Merge branch 'master' of https://github.com/irinakim12/pico-examples

e277c22

Update README.adoc

7e305b4

Update README.adoc

58099e4

Update README.adoc

ed2374f

aallan added enhancement New feature or request paused Waiting for internal availability labels Apr 6, 2021

lurch reviewed Apr 6, 2021

View reviewed changes

spi/w5500_spi/w5500_spi.c

#include "loopback.h"

/* Example code to talk to a wiznet MEMS accelerometer and gyroscope.

Copy link

Contributor

lurch Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh? 😉

lurch reviewed Apr 6, 2021

View reviewed changes

irinakim12 added 2 commits April 7, 2021 11:18

Modified Readme & deleted the .gitignore

5927103

I fix indentation. Thank you

1ee2c51

lurch reviewed Apr 7, 2021

View reviewed changes

spi/w5500_spi/README.adoc Outdated Show resolved Hide resolved

lurch reviewed Apr 7, 2021

View reviewed changes

I fixed indentation and README document

cf1c61c

lurch reviewed Apr 20, 2021

View reviewed changes

Adding space in "communication command"

9384b20

aallan removed the paused Waiting for internal availability label Jun 25, 2021

aallan suggested changes Jul 20, 2021

View reviewed changes

aallan mentioned this pull request Jul 28, 2021

Add example for the W5500 Ethernet chip #147

Closed

aallan closed this Jul 28, 2021

		#include "loopback.h"


		/* Example code to talk to a wiznet MEMS accelerometer and gyroscope.

		@@ -0,0 +1,59 @@
		= Attaching a W5500 via SPI

		This example code shows how to interface the Raspberry Pi Pico to the WIZ850io(W5500) board. The particular device used can be interfaced via SPI, we are using SPI, and interfacing at 3.3v.

Added Ethernet example(W5500 of WIZnet product) using SPI #98

Added Ethernet example(W5500 of WIZnet product) using SPI #98

Uh oh!

Conversation

irinakim12 commented Apr 5, 2021

Uh oh!

aallan commented Apr 6, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aallan commented Jun 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aallan commented Jul 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aallan commented Jul 20, 2021

Uh oh!

aayushijhaveri commented Jul 20, 2021

Uh oh!

aallan commented Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aallan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

aallan commented Jun 25, 2021 •

edited

Loading

aallan commented Jul 1, 2021 •

edited

Loading

aallan commented Jul 20, 2021 •

edited

Loading