Remove cloudpickle customization and just use plain cloudpickle.

[robertnishihara]

I'm a little surprised that the cloudpickle modifications no longer seem to be necessary. I thought we needed those changes in order to pickle remote functions that invoked other remote functions.

@mehrdadn, do you remember any examples of functions that can't be pickled normally by cloudpickle but that could be pickled with the augmented version? I can't seem to recreate such an example at the moment.

The problem probably still exists, so if that's the case we should see if we can create a patch for cloudpickle.

[mehrdadn]

I have an example in my bug report here. It doesn't seem to have been marked as resolved, so I expect it to still be broken in the latest version of CloudPickle.

[AmplabJenkins]

Merged build finished. Test PASSed.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/882/
Test PASSed.

[robertnishihara]

Thanks @mehrdadn. The reason we didn't submit your patch to cloudpickle was that it only works for CPython, is that right?

[mehrdadn]

Yup.

[wesm]

see also https://github.com/spartan-array/spartan/blob/master/spartan/cloudpickle.pyx, a cythonized version of cloudpickle

[robertnishihara]

Thanks for the link!

[pcmoritz]

@wesm Thanks for the link! Did you try it out by any chance and measure the speed vs. regular cloudpickle?

[robertnishihara]

The test failure here is #591.

[AmplabJenkins]

Merged build finished. Test PASSed.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/886/
Test PASSed.

[wesm]

I haven't tested it personally but it may be worth evaluating at some point

[pcmoritz]

mehrdad is fixing this whole class of problems upstream here: cloudpipe/cloudpickle#89