Skip to content

Shapes #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 24, 2017
Merged

Shapes #89

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
817821b
test
macrozone Oct 16, 2017
52f4de6
test
macrozone Oct 16, 2017
75a6372
update
macrozone Oct 16, 2017
9786239
wip
macrozone Oct 16, 2017
775608c
wip
macrozone Oct 16, 2017
c927c84
Merge branch 'shapes' of https://github.com/panter/react-native-arkit…
macrozone Oct 16, 2017
c74b021
fix crash in onFeaturesDetected
macrozone Oct 17, 2017
5049bfd
improve
macrozone Oct 17, 2017
d543c5c
fix crash in onFeaturesDetected
macrozone Oct 17, 2017
aea7a5a
improve
macrozone Oct 17, 2017
d336c84
Merge branch 'feature-points' into shapes
macrozone Oct 17, 2017
9225b47
update installation instruction
macrozone Oct 17, 2017
661eb82
add more shape properties
macrozone Oct 17, 2017
5f1dc08
normalize chamferProfile path
macrozone Oct 17, 2017
4b96788
update readme
macrozone Oct 17, 2017
26617f9
change dep
macrozone Oct 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve
  • Loading branch information
@macrozone
macrozone committed Oct 17, 2017
commit 5049bfd9af79df6cd6a246b9d37fd7f8d9c16d83
35 changes: 18 additions & 17 deletions ios/RCTARKit.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,26 +435,27 @@ - (void)session:(ARSession *)session didUpdateFrame:(ARFrame *)frame {
}
}
if (self.onFeaturesDetected) {
NSMutableArray * featurePoints = [NSMutableArray array];
for (int i = 0; i < frame.rawFeaturePoints.count; i++) {
vector_float3 point = frame.rawFeaturePoints.points[i];

NSString * pointId = [NSString stringWithFormat:@"featurepoint_%lld",frame.rawFeaturePoints.identifiers[i]];

[featurePoints addObject:@{
@"x": @(point[0]),
@"y": @(point[1]),
@"z": @(point[2]),
@"id":pointId,
}];

}
dispatch_async(dispatch_get_main_queue(), ^{

NSMutableArray * featurePoints = [NSMutableArray array];
for (int i = 0; i < frame.rawFeaturePoints.count; i++) {
vector_float3 point = frame.rawFeaturePoints.points[i];

NSString * pointId = [NSString stringWithFormat:@"featurepoint_%lld",frame.rawFeaturePoints.identifiers[i]];

[featurePoints addObject:@{
@"x": @(point[0]),
@"y": @(point[1]),
@"z": @(point[2]),
@"id":pointId,
}];

}

if(self.onFeaturesDetected) {
self.onFeaturesDetected(@{
@"featurePoints":featurePoints
});
self.onFeaturesDetected(@{
@"featurePoints":featurePoints
});
}
});
}
Expand Down