Correct console log message for react-native android #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: build before publishing * fix(tests): use jest.doMock instead of setMock * chore: rename local-cli -> cli
* chore: setup monorepo with lerna * chore: move flow to root * fix: lint * chore: add watch command
Add simple logger.
Introduce logger to bundle core and eject
Member
|
Thank you! I am going to merge it now! I decided to slightly change your PR to unify the command with iOS messages. Asking to run "eject" is an assumption - in most cases people are aware that they are working with an Expo project (which is not a React Native project per se). |
Member
|
Would you mind rebasing your PR? There were some changes (files moved around) in the meantime which makes it hard to rebase. |
…116) * feat: use ctx.root instead of process.cwd() in several commands * test: upgrading patch version of jest to avoid worker system bug
arnabsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-native android is not a valid command. react-native eject will recreate the missing native folder.
Test Plan
Release Notes
[CLI] [BUGFIX] [local-cli/runAndroid/runAndroid.js] - Correct console log message to react-native eject