Skip to content

Allow out of tree platforms to work without custom metro configs #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 8, 2020
Merged

Allow out of tree platforms to work without custom metro configs #1115

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a76e6ce
Allow out of tree platforms to work without custom metro configs
acoates-ms Apr 15, 2020
744a769
Need to add the platofrm specifc InitializeCore to getModulesRunBefor…
acoates-ms May 6, 2020
452b175
lock
acoates-ms May 6, 2020
c5481d1
Add npmPackageName to schema
acoates-ms May 7, 2020
121ea01
Some documentation
acoates-ms May 7, 2020
001874e
Use finally to restore resolveRequest
acoates-ms May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Need to add the platofrm specifc InitializeCore to getModulesRunBefor… 
…eMainModule
  • Loading branch information
@acoates-ms
acoates-ms committed May 6, 2020
commit 744a769b8d23ad3dc567b999ed85f38ac94c3353
1 change: 1 addition & 0 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"metro-config": "^0.58.0",
"metro-core": "^0.58.0",
"metro-react-native-babel-transformer": "^0.58.0",
"metro-resolver": "^0.58.0",
"minimist": "^1.2.0",
"mkdirp": "^0.5.1",
"node-stream-zip": "^1.9.1",
Expand Down
25 changes: 18 additions & 7 deletions packages/cli/src/tools/loadMetroConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,29 +55,40 @@ export interface MetroConfig {
* Default configuration
*/
export const getDefaultConfig = (ctx: Config): MetroConfig => {
const outOfTreePlatforms = Object.keys(ctx.platforms).filter(
platform => ctx.platforms[platform].npmPackageName,
);

return {
resolver: {
resolveRequest:
Object.keys(ctx.platforms).filter(
platform => ctx.platforms[platform].npmPackageName,
).length === 0
outOfTreePlatforms.length === 0
? undefined
: reactNativePlatformResolver(
Object.keys(ctx.platforms)
.filter(platform => ctx.platforms[platform].npmPackageName)
.reduce<{[platform: string]: string}>((result, platform) => {
outOfTreePlatforms.reduce<{[platform: string]: string}>(
(result, platform) => {
result[platform] = ctx.platforms[platform].npmPackageName!;
return result;
}, {}),
},
{},
),
),
resolverMainFields: ['react-native', 'browser', 'main'],
platforms: [...Object.keys(ctx.platforms), 'native'],
},
serializer: {
// We can include multiple copies of InitializeCore here because metro will
// only add ones that are already part of the bundle
getModulesRunBeforeMainModule: () => [
require.resolve(
path.join(ctx.reactNativePath, 'Libraries/Core/InitializeCore'),
),
...outOfTreePlatforms.map(platform =>
require.resolve(
`${ctx.platforms[platform]
.npmPackageName!}/Libraries/Core/InitializeCore`,
),
),
],
getPolyfills: () =>
require(path.join(ctx.reactNativePath, 'rn-get-polyfills'))(),
Expand Down