Skip to content

refactor: use the cli-server-api package #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2020
Merged

refactor: use the cli-server-api package #1140

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ba3a5a4
refactor: use the cli-server-api package
fson Apr 14, 2020
d768303
Rename `server` folder to `start`
fson Apr 28, 2020
9c3bb79
Fix debugger always opening
Esemesek May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix debugger always opening
  • Loading branch information
@Esemesek
Esemesek committed May 8, 2020
commit 9c3bb79e5d69ebb98e710a3377292eab179a4481
1 change: 1 addition & 0 deletions packages/cli-server-api/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export function createDevServerMiddleware(options: MiddlewareOptions) {
'/message',
);
broadcast = messageSocket.broadcast;
isDebuggerConnected = debuggerProxy.isDebuggerConnected;
Copy link
Member

@thymikee thymikee May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @fson the debugger connected state was not updated, likely an oversight when moving code around

const eventsSocket = eventsSocketServer.attachToServer(
server,
'/events',
Expand Down