Skip to content

Conversation

@misaku
Copy link

@misaku misaku commented Jan 28, 2019

Summary:

Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle
issue:23176
i found this fix in past commit (0.57) and i submit again.

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Changelog:

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Test Plan:

in windows run react-native link and start error, Backslashes is the escape character and will result in an invalid path in settings.gradle

Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle
  [issue:23176]( facebook/react-native#23176)
  i found this fix in past commit (0.57) and i submit again.

Changelog:
----------

[Android] [Fixed] - Fix for Windows Backslashes is the escape character and will result in an invalid path in settings.gradle

Test Plan:
----------

in windows run react-native link and start error,  Backslashes is the escape character and will result in an invalid path in settings.gradle
@thymikee
Copy link
Member

Hey @misaku, thanks for the PR, but this issue is already handled by this diff: #130.

Please check if it resolves the problem for you and leave a comment there.

@thymikee thymikee closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants