Skip to content

Conversation

@ivanzamanov
Copy link

@ivanzamanov ivanzamanov commented Oct 14, 2024

Summary:

Fixes #2528

Read config process output before awaiting exit code, thus allowing output larger than the OS pipe buffer to be output.

Test Plan:

Simply make sure output from the config process is read correctly even if output exceeds the buffer size.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@ivanzamanov ivanzamanov changed the title fix: read config process output before waiting exit code (#2528) fix: read config process output before waiting exit code #2528 Oct 14, 2024
@cortinico
Copy link
Member

The logic in this file is not used anymore in 0.75/0.76 and is kept only for compatibility. We should probably remove it from this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build waits forever for config process if output does not fit in buffer

2 participants