build(server-api): upgrade pretty-format to 29.7.0 #2656
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation: The React Native core repository throws some warnings when installing fresh dependencies as it has some incompatible resolutions for
react-is. Digging deeper into it, I noticedpretty-format@^26.6.2(which comes from this repo) hasreact-is "^17.0.1"as a dependency, and this causes one of the warnings.Saw this as an opportunity to bump this and get rid of one of them.
See:
Test Plan
CI should be green, and I also did a sanity check that nothing breaks in the
serializeMessagefunction by linking the CLI to a newly created react native project and then runningyarn react-native infoCode snippet (can be added at the bottom of packages/cli-server-api/src/websocket/createEventsSocketEndpoint.ts):
Output:
(base) user/textinputreproducer (main) % yarn react-native info yarn run v1.22.22 $ /Users/user/Documents/textinputreproducer/node_modules/.bin/react-native info Serialized generic error event: {"type":"report","error":"[Error: Something went wrong]","timestamp":1746041941646} Serialized client_log event: {"type":"client_log","data":["User clicked button","{\"action\": \"click\", \"details\": {\"buttonId\": 42}, \"user\": \"testUser\"}","[1, 2, {\"nested\": \"object\"}]"]} Serialized plain message: {"type":"info","message":"Everything is fine"} info Fetching melo system and libraries information...Checklist
react-nativecheckout (instructions).