Skip to content

Conversation

@aleclarson
Copy link
Contributor

Summary:

In node_modules, follow symlinks until the "real path" is found.

Migrated from here: facebook/react-native@fa6191f

Test Plan:

None yet.

@aleclarson aleclarson changed the title fix(cli): follow symlinks until a non-symlink is found Follow symlinks until a non-symlink is found Mar 31, 2019
@grabbou
Copy link
Member

grabbou commented Apr 10, 2019

Mind fixing tests and adding one test case to cover this scenario?

@aleclarson
Copy link
Contributor Author

When I can find time, but it'll be a while.

@thymikee
Copy link
Member

thymikee commented May 17, 2019

@aleclarson this looks good but I'd like to add more an extra test. Added a check for visited array size, which fixes both unit tests and my test setup.

Btw while testing this I've finally found a way for us to run linked start command:

# when @react-native-community/cli is linked
REACT_NATIVE_APP_ROOT=/path/to/react-native-cli yarn react-native start
# or when it's not
REACT_NATIVE_APP_ROOT=/path/to/react-native-cli node /path/to/react-native-cli/packages/cli/build start

cc @grabbou @pbitkowski

@grabbou
Copy link
Member

grabbou commented Jan 30, 2020

I am going to close this due to inactivity. Feel free to re-open or submit once again with addressed changes.

@grabbou grabbou closed this Jan 30, 2020
@rajatgyl
Copy link

I am getting this error while running with react-native run-android command however I was able to run this with the command react-native run-android --deviceId {DEVICE ID IN ADB DEVICES}.
issue but can not run this with react-native run-android command.
{
react-native-cli: 2.0.1
react-native: 0.54.2
}

@thymikee
Copy link
Member

You have ancient RN version. This cli ships with 0.59. Please upgrade if you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants