Skip to content

Fix metro config when running from source #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grabbou merged 3 commits into from
Jan 15, 2019
Merged

Fix metro config when running from source #56

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49d1d04
Fix metro config when running from source
grabbou Dec 19, 2018
0880784
nit
grabbou Dec 19, 2018
9697e90
Few tweaks
grabbou Jan 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 19 additions & 42 deletions packages/local-cli/util/loadMetroConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,12 @@ const getDefaultConfig = (root: string) => {
'react-native',
...plugins.haste.providesModuleNodeModules,
],
hasteImplModulePath: require.resolve('react-native/jest/hasteImpl'),
},
serializer: {
getModulesRunBeforeMainModule: () => [
require.resolve('react-native/Libraries/Core/InitializeCore'),
],
getPolyfills: require('react-native/rn-get-polyfills'),
getPolyfills: () => require('react-native/rn-get-polyfills')(),
},
server: {
port: process.env.RCT_METRO_PORT || 8081,
Expand All @@ -64,9 +63,6 @@ const getDefaultConfig = (root: string) => {
babelTransformerPath: require.resolve(
'metro-react-native-babel-transformer'
),
assetRegistryPath: require.resolve(
'react-native/Libraries/Image/AssetRegistry'
),
},
watchFolders: getWatchFolders(),
};
Expand All @@ -82,40 +78,6 @@ export type ConfigOptionsT = {
config?: string,
};

/**
* Overwrites Metro configuration with options.
*
* This ensures that options are always taking precedence over other
* configuration present.
*/
const overwriteWithOptions = (config: ConfigT, options: ConfigOptionsT) => {
if (options.maxWorkers) {
config.maxWorkers = options.maxWorkers;
}

if (options.port) {
config.server.port = options.port;
}

if (options.reporter) {
config.reporter = options.reporter;
}

if (options.resetCache) {
config.resetCache = options.resetCache;
}

if (options.watchFolders) {
config.watchFolders = options.watchFolders;
}

if (options.sourceExts && options.sourceExts !== config.resolver.sourceExts) {
config.resolver.sourceExts = options.sourceExts.concat(
config.resolver.sourceExts
);
}
};

/**
* Loads Metro Config and applies `options` on top of the resolved config.
*
Expand All @@ -130,13 +92,28 @@ module.exports = async function load(
const config = await loadConfig(
{
cwd: projectRoot,
config: options.config,
...options,
},
defaultConfig
);

if (options) {
overwriteWithOptions(config, options);
/**
* Workaround for static Metro configuration. If the following properties are defined
* in user space, the following code will not run.
*
* That makes it possible to run CLI in context of `react-native` source code, where
* the package does not exist under `node_modules`.
*/
if (config.resolver.hasteImplModulePath === undefined) {
config.resolver.hasteImplModulePath = require.resolve(
'react-native/jest/hasteImpl'
);
}

if (config.transformer.assetRegistryPath === 'missing-asset-registry-path') {
config.transformer.assetRegistryPath = require.resolve(
'react-native/Libraries/Image/AssetRegistry'
);
}

return config;
Expand Down