Add allowsExternalPlayback Property for ios#1057
Merged
cobarx merged 6 commits intoTheWidlarzGroup:masterfrom Jun 10, 2018
Merged
Add allowsExternalPlayback Property for ios#1057cobarx merged 6 commits intoTheWidlarzGroup:masterfrom
cobarx merged 6 commits intoTheWidlarzGroup:masterfrom
Conversation
cobarx
suggested changes
Jun 8, 2018
Contributor
cobarx
left a comment
cobarx
left a comment
There was a problem hiding this comment.
Looks great. Can you add an entry in the README for this prop.
ios/RCTVideo.m
Outdated
| _controls = NO; | ||
| _playerBufferEmpty = YES; | ||
| _playInBackground = false; | ||
| _allowsExternalPlayback = YES; |
Contributor
There was a problem hiding this comment.
The indentation is off here.
Contributor
Author
|
I have updated the README. |
cobarx
approved these changes
Jun 10, 2018
Contributor
|
Thanks for updating this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the video control can disable allowsExternalPlayback for ios