Skip to content

resolve.alias should be resolve.root #28 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

resolve.alias should be resolve.root #28 #29

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac8f7a3
resolve.alias should be resolve.root #28
wassname Apr 5, 2016
32959b5
Keep the alias for config
wassname Apr 5, 2016
a6d65df
Add slash
wassname Apr 5, 2016
3a5fa7c
Webpack test.js uses resolve.root too
wassname Apr 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Webpack test.js uses resolve.root too 
I realised I should make the change in the test config as well. 

And it seems to better if the test config inherits from baseConfig and defaultSettings where possible, so I did that. That way you are testing as close to your actual config as possible. Especially because there is one test of the config path.
  • Loading branch information
@wassname
wassname committed Apr 6, 2016
commit 3a5fa7c80f0efc57254ea8381254f20d68e7bf49
17 changes: 6 additions & 11 deletions cfg/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
'use strict';

let path = require('path');
let srcPath = path.join(__dirname, '/../src/');

let defaultSettings = require('./defaults');
let baseConfig = require('./base');

// Add needed plugins here
Expand Down Expand Up @@ -40,15 +39,11 @@ module.exports = {
},
resolve: {
extensions: [ '', '.js', '.jsx' ],
alias: {
actions: srcPath + 'actions/',
helpers: path.join(__dirname, '/../test/helpers'),
components: srcPath + 'components/',
sources: srcPath + 'sources/',
stores: srcPath + 'stores/',
styles: srcPath + 'styles/',
config: srcPath + 'config/' + process.env.REACT_WEBPACK_ENV
}
root: [].concat(
baseConfig.resolve.root,
[`${defaultSettings.srcPath}/test`]
),
alias: baseConfig.resolve.alias
},
plugins: [
new BowerWebpackPlugin({
Expand Down