Skip to content

Inconsistent Product Image of Cart Item #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brent-hoover merged 5 commits into from
May 2, 2017
Merged

Inconsistent Product Image of Cart Item #2171

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88924da
fix inconsistent cartItem image and productField console error
abdulsemiu-atanda Apr 27, 2017
21c8547
fix fetching too many records from media
abdulsemiu-atanda Apr 27, 2017
7529b6f
fix fetching archived images to client
abdulsemiu-atanda Apr 28, 2017
915ecaa
fix display variant/product image for item without image
abdulsemiu-atanda May 1, 2017
1c26435
Merge branch 'development' into atanda-inconsistent-product-image-2115
abdulsemiu-atanda May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix display variant/product image for item without image
  • Loading branch information
@abdulsemiu-atanda
abdulsemiu-atanda committed May 1, 2017
commit 915ecaa4b9477aa2162e86c9795de3d01732e6e6
9 changes: 8 additions & 1 deletion imports/plugins/core/checkout/client/container/cartDrawerContainer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,19 @@ function composer(props, onData) {
const userId = Meteor.userId();
const shopId = Reaction.getShopId();
let productItems = Cart.findOne({ userId, shopId }).items;
let defaultImage;

productItems = productItems.map((item) => {
Meteor.subscribe("CartItemImage", item);
const defaultImage = Media.findOne({
defaultImage = Media.findOne({
"metadata.variantId": item.variants._id
});
if (defaultImage) {
return Object.assign({}, item, { defaultImage });
}
defaultImage = Media.findOne({
"metadata.productId": item.productId
});
return Object.assign({}, item, { defaultImage });
});
onData(null, {
Expand Down
2 changes: 0 additions & 2 deletions server/publications/collections/cart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,9 @@ Meteor.publish("Cart", function (sessionId, userId) {

Meteor.publish("CartItemImage", function (cartItem) {
check(cartItem, Match.Optional(Object));
const variantId = cartItem.variants._id;
const productId = cartItem.productId;

return Media.find({
"metadata.variantId": variantId,
"metadata.productId": productId,
"metadata.workflow": { $nin: ["archived"] }
});
Expand Down