Closed
Conversation
drubiodev
reviewed
Mar 7, 2018
| points: { | ||
| type: Sequelize.INTEGER, | ||
| }, | ||
| messages: { |
Author
bot/client.js
Outdated
| }); | ||
|
|
||
| client.on('guildMemberAdd', (member) => { | ||
| member.sendMessage('Welcome to the channel!'); |
Owner
There was a problem hiding this comment.
Why is this feature in your DB scheme branch? This was never merged into the dev branch, so it should not be here unless you have not followed the DWA branch model.
|
|
||
| module.exports = { | ||
| up: (queryInterface, Sequelize) => queryInterface.addColumn("Members", "messagesCount", { | ||
| type: Sequelize.INTEGER, |
Owner
There was a problem hiding this comment.
Does this column matter as per my previous comments about not needing to count the messages, but rather apply a point transformation onto the user's point total upon a message being sent
Author
There was a problem hiding this comment.
We wanted to track who has sent the most messages as well. Of course, this won't start tracking until the merge. But as a reward, we want to track message count.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to run this locally, you need to delete the tables in your MySQL DB manually before you
docker-compose up --build