Conversation
bot/controllers/verify.js
Outdated
| const emailBodyString = `<table><tr><td><p>Enter the code below into Discord, in the same channel on the Armada Server. Verification will timeout after ${(timeoutInMiliseconds / 1000) / 60} minutes from first entering the !verify command.</p></td></tr><tr><td><h2>Verification Code: ${code}</h2></td></tr></table>`; | ||
| sendEmail(message, email, emailSubject, emailBodyString, emailType, (sendStatus) => { | ||
| if (sendStatus) { | ||
| const numPointToAdd = 1; |
There was a problem hiding this comment.
Question, could this be deleted? I'm not sure why points would be added in the verify file when all they are doing is becoming verified. This could probably be deleted.
There was a problem hiding this comment.
I thought that verifying could warrant the users first point. What did you think? I could take it out.
There was a problem hiding this comment.
Maybe take out that section and in the part where it creates the new member instead of setting it to 0 it could be set to a variable of 1. Just a thought since that part already sets it to zero to begin. We could have it start with 1 points instead of 0. It does make sense to reward them with at least a point for verifying though, you're right.
There was a problem hiding this comment.
Yea, that makes more sense to keep it dry.
krogers78
left a comment
krogers78
left a comment
There was a problem hiding this comment.
Everything looks good to me after the change!
|
LGTM |
3 participants
Email function added to botUtils.js.