Conversation
…ming them to the server and a message in general chat
|
Everything works fine for me, maybe consider changing the welcome command to !tos or change it's description in the help menu to say it is sending the tos since that's the main reason a user would use that command |
bot/client.js
Outdated
| client.on('guildMemberAdd', (member) => { | ||
| member.sendMessage(`${member.user.username}, Welcome to the Full Sail Armada! These are the terms of service...`); | ||
| // Send welcome message to members who join | ||
| member.sendMessage(`${member}, Welcome to the Full Sail Armada! These are the terms of service...`); |
There was a problem hiding this comment.
"sendMessage" is being deprecated, please change those methods to just "send" before continuing.
brennondenny
left a comment
brennondenny
left a comment
There was a problem hiding this comment.
Add in the default comments found across the controllers to your welcome.js file.
| @@ -0,0 +1,24 @@ | |||
| const BaseController = require('../baseController.js'); | |||
| const Command = require('../baseCommand.js'); | |||
|
|
|||
There was a problem hiding this comment.
Add in the default comments found across the controllers to your welcome.js file.
reactivepixel
left a comment
reactivepixel
left a comment
There was a problem hiding this comment.
Very good work incorporating the feedback from your peers in shaping this submission. Ideally, I would have like you to solve the duplicate code logic issue out of the gate, but all submissions seem to have missed this, and we will discuss this further on Wednesday. The idea there would be to invoke the controller you have built rather than manually sending a message in the guildadduser event. Either way, solid work!
bot/client.js
Outdated
| // Send message to specific channel on the server | ||
| const channel = member.guild.channels.find('name', 'general'); | ||
| // If channel is not found do nothing | ||
| if (!channel) return; |
There was a problem hiding this comment.
This is a non-intuitive way to 'do nothing'.
bot/client.js
Outdated
| // Event listener for new members | ||
| client.on('guildMemberAdd', (member) => { | ||
| // Send welcome message to members who join | ||
| member.send(`${member}, Welcome to the Full Sail Armada! These are the terms of service...`); |
There was a problem hiding this comment.
Duplicate logic in your controller.
bot/client.js
Outdated
| // If channel is not found do nothing | ||
| if (!channel) return; | ||
| // Send message with members name | ||
| channel.send(`Welcome to the Full Sail Armada ${member}! for more information use !help`); |
There was a problem hiding this comment.
The announcement to the general channel should not have a !help cmd reminder. This should be in the welcome message if anywhere.
| '!tos', | ||
| '!tos', | ||
| 'Terms of Service', | ||
| 'Resends terms of service message.', |
There was a problem hiding this comment.
Good phrasing on your help message
4 participants
!welcome command.
sends welcome message to new users and a message to the general chat.
use !welcome to resend the welcome message.