Skip to content

JATaber twitch notification #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brennondenny merged 19 commits into from
May 21, 2018
Merged

JATaber twitch notification #156

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9faaa0a
hopefully this goes to the correct spot this time
May 8, 2018
a60894e
setting up feature
May 13, 2018
71601c0
added a controller for the twitch Notifier
May 14, 2018
05c8d60
working on the controller for the adding of the streamer
May 14, 2018
be7ac2a
working on controller and found spelling error in another controller
May 14, 2018
5c0996b
stopped to get Client_ID from twitch
May 17, 2018
920bdaa
changing from automated to manual
May 17, 2018
2e06256
changing some variables around
May 17, 2018
a8227dc
finishing up command
May 17, 2018
88dd7aa
bot command printing to proper channel
May 17, 2018
245b8a0
fixed some wording for the announcement message
May 17, 2018
9a150aa
fixed channel Id to the Armada twitch challenel ID
May 17, 2018
b6d4633
making the channel finder more dynamic
May 19, 2018
637e0c3
removing previous feature from the project
May 19, 2018
f814132
removing previous feature from the project
May 19, 2018
9faa088
refactored a file name and made it to where a user can stream from tw…
May 19, 2018
fe2f51d
fixed a lint error
May 19, 2018
cddda06
Merge branch 'Release2' into JATaber_twitch_notification
May 19, 2018
7c7850c
Update roles.js
May 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
changing some variables around
  • Loading branch information
James Taber authored and James Taber committed May 17, 2018
commit 2e0625699bedd2f84014eaff3296bd45c0c74bef
7 changes: 3 additions & 4 deletions bot/controllers/twitchLive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,15 @@ class StreamerLiveController extends BaseController {
'!twitchLive',
Copy link
Contributor

@brennondenny brennondenny May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since your goal is to make the StreamerLiveController generic, consider changing the command too!live and add a service attribute, for example !live twitch myname mygame.

Copy link
Author

@JATaber JATaber May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to implement this method making one command good for twitch or mixer

'!twitchLive <twitch_name>',
'Twitch Live',
'A quick easy way to ',
'A quick easy way to announce you are going live on Twitch.',
Copy link

@mattpezzente mattpezzente May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar suggestion:

'A quick easy way...'
vs.
'A quick and easy way...'

Copy link
Author

@JATaber JATaber May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed the grammar issue.

this.addTwitchAction.bind(controller),
),
];
}
addTwitchAction() {
Copy link

@mattpezzente mattpezzente May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would naming this to something like "announceTwitchLive" be more appropriate?

Copy link
Contributor

@brennondenny brennondenny May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing this to "streamerLiveAction" to better fit the overall functionality.

Copy link
Author

@JATaber JATaber May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the method name

Copy link
Contributor

@brennondenny brennondenny May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing this to "streamerLiveAction" to better fit the overall functionality.

Copy link
Author

@JATaber JATaber May 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the method name.

const { message } = this;
const streamName = message.parsed[1];
const twitchClientID = '';
const nameList = {};
const twitchName = message.parsed[1];
const nameList = `https://www.twitch.tv/${twitchName}`;
}
}
module.exports = StreamerLiveController;