Skip to content

Mini games feature #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JATaber merged 12 commits into from
May 22, 2018
Merged

Mini games feature #165

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ee47613
started to set up the feature
May 20, 2018
342e9ba
setting up a layout for commands
May 20, 2018
cb531fd
working on getting variable to populate from https.request
May 21, 2018
c9169c3
trying to get dadJoke to store outside the https request
May 21, 2018
2e9e2f0
working on the dice roll
May 21, 2018
41b2d1d
finished the coinflip
May 21, 2018
474791a
working on the magic 8ball
May 21, 2018
9b3b25e
working on the API call
May 21, 2018
de70549
dad joke works right after it thinks it breaks
May 21, 2018
fe7e9c5
fixing a lint issue
May 22, 2018
60ec984
fixed dadJoke error
May 22, 2018
805c381
added 8ball description
May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed dadJoke error
  • Loading branch information
James Taber authored and James Taber committed May 22, 2018
commit 60ec9843be118aadb71f68682708b84c94a2f5f1
3 changes: 2 additions & 1 deletion bot/controllers/games.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ class GamesController extends BaseController {
};
fetch('https://icanhazdadjoke.com/', options)
.then(res => res.text())
.then(body => message.reply(`Here is your joke ${message.author.username}!! ${body}`));
.then(body => message.channel.send(`Here is your joke ${message.author.username}!! ${body}`));
return 'Want to hear a joke?';
}
}

Copy link

@mattpezzente mattpezzente May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible solution to this would be to use async / await for the fetch, that way the reply waits for the joke to return before posting.

Copy link
Author

@JATaber JATaber May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function is already an async function

Expand Down