Conversation
|
I have tested your bot locally and it works perfectly! Good Job! |
mattpezzente
left a comment
mattpezzente
left a comment
There was a problem hiding this comment.
Changes requested aren't critical to project functionality, but should be attempted as time allows before merging.
| const { message } = this; | ||
| const question = message.parsed[1]; | ||
| const questionSpaced = question.split('-').join(' '); | ||
| const content = message.content; |
There was a problem hiding this comment.
I'm picking up a linting issue here, even though it seems to have gone through the tests successfully. However, I do recommend de-structuring it:
const { content } = messsage;
There was a problem hiding this comment.
Not sure why you're getting that linting issue, I don't see it and like you said it does pass the CircleCI test. I'm using content to convert the message.content into a usable string, but still need to use const {message} = message} so I get the initial information from Discord.
| options += `\r ️\u0039\u20E3${message.parsed[i]}`; | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Add a space between the special characters and the poll options for minor readability improvement
| } else if (i === 10) { | ||
| message.react('\u0039\u20E3'); | ||
| } | ||
| } |
There was a problem hiding this comment.
If I'm reading this correctly, I believe that this can be improved without doing multiple checks? For example:
message.react(`\u003${i}\u20E3`);
There was a problem hiding this comment.
While this is a better way to solve this, the Style Guide restricts incomplete unicode like \u003${i}.
|
Poll and Question worked for me and I didn't see any issues. |
4 participants
This feature adds in the !question and !poll commands to Max Bot. Once the bot is up and running locally type !help for information on how to use the commands.