Merged
Conversation
syntax: !loop [time in seconds] [message to be looped] example: !loop 20 Max-bot is constantly in operation and will loop this statement every 20 seconds
syntax: !loop [time in seconds] [message to be looped] example: !loop 20 Max-bot is constantly in operation and will loop this statement every 20 seconds I feel as though someone can come along later and upgrade this function to maybe include more loops or format it better for time.
Codemax999
reviewed
Jun 18, 2018
|
|
||
| // Check if the pre-existing toggle is true or false | ||
| // If the toggle is true, then set the toggle to false and turn off the loop | ||
| if (toggle !== false) { |
Contributor
There was a problem hiding this comment.
Can simplify with if (toggle) ...
Codemax999
reviewed
Jun 18, 2018
| clearInterval(interval); | ||
| newMessage.channel.send("Loop is off"); | ||
| toggle = false; | ||
| } else if (toggle !== true) { |
Contributor
There was a problem hiding this comment.
Can simplify with else if (!toggle)...
Codemax999
reviewed
Jun 18, 2018
Contributor
Codemax999
left a comment
Codemax999
left a comment
There was a problem hiding this comment.
Awesome, added some small things about handling booleans. Other than that LGTM!
Contributor
Author
|
Thank you much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syntax: !loop [time in seconds] [message to be looped]
example: !loop 20 Max-bot is constantly in operation and will loop this statement every 20 seconds
I feel as though someone can come along later and upgrade this function to maybe include more loops or format it better for time.