Skip to content

Expose MaxUsagesPerEngine as an configuration option in React.NET #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2017
Merged

Expose MaxUsagesPerEngine as an configuration option in React.NET #416

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f512b06
Expose MaxUsagesPerEngine as an configuration option in React.NET
Halstatt Jun 12, 2017
a54470a
Added forwarding of stack traces from React.NET console mock
Halstatt Jun 26, 2017
80839fa
Merge branch 'master' into master
Daniel15 Jul 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'master' into master
  • Loading branch information
@Daniel15
Daniel15 authored Jul 2, 2017
commit 80839fa5e6d024686b65595b35f341b3261417a9
12 changes: 2 additions & 10 deletions src/React.Core/Resources/shims.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,14 @@ MockConsole.prototype = {
serializedArgs.push(JSON.stringify(arguments[i]));
}

var callstack = this._getCallStack();

this._calls.push({
method: methodName,
args: serializedArgs,
stack: callstack ? '"Call stack: ' + callstack : 'not available'
stack: '\nCall stack: ' + (new Error().stack || 'not available')
});
},
_formatCall: function(call) {
return 'console.' + call.method + '("[.NET]", ' + call.args.join(', ') + ',' + call.stack + ');';
},
_getCallStack: function() {
var stack = new Error().stack;
return stack
? stack.replace(/[\n\r]/g, '\\n') + '"'
: '';
return 'console.' + call.method + '("[.NET]", ' + call.args.join(', ') + ', ' + JSON.stringify(call.stack) + ');';
},
getCalls: function() {
return this._calls.map(this._formatCall).join('\n');
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.