Skip to content

Component name valid caching #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2018
Merged

Component name valid caching #529

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eac24b
component name valid cache
DaniilSokolyuk Apr 8, 2018
249a8bd
ordinal comparer for better performance
DaniilSokolyuk Apr 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ordinal comparer for better performance
  • Loading branch information
@DaniilSokolyuk
DaniilSokolyuk committed Apr 8, 2018
commit 249a8bdfd9ad9f4a5476eb0530f2d52e0a68fe07
2 changes: 1 addition & 1 deletion src/React.Core/ReactComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace React
/// </summary>
public class ReactComponent : IReactComponent
{
private static readonly ConcurrentDictionary<string, bool> _componentNameValidCache = new ConcurrentDictionary<string, bool>();
private static readonly ConcurrentDictionary<string, bool> _componentNameValidCache = new ConcurrentDictionary<string, bool>(StringComparer.Ordinal);

/// <summary>
/// Regular expression used to validate JavaScript identifiers. Used to ensure component
Expand Down