Skip to content

Disabled tabs should remain keyboard focusable as per W3C WAI ARIA guidelines #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jastagar wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Disabled tabs should remain keyboard focusable as per W3C WAI ARIA guidelines #538

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1181e5e
Tab switching is more accessable.
Jastagar Dec 2, 2023
5a68264
Merge branch 'main' of https://github.com/Jastagar/react-tabs
Jastagar Dec 2, 2023
86ddd5d
Removed a consolelog
Jastagar Dec 2, 2023
df11681
added and remove some comments
Jastagar Dec 2, 2023
81945cc
added and removed some comments
Jastagar Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
added and removed some comments
  • Loading branch information
@Jastagar
Jastagar committed Dec 2, 2023
commit 81945cc11395c72fb05f16fed491695c9092dea5
1 change: 0 additions & 1 deletion src/components/TabPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ const TabPanel = (props) => {
id={`panel${id}`}
aria-labelledby={`tab${id}`}
>
{/* {forceRender || selected ? children: null} */}
{forceRender || selected ? !disabled? children: DisabledComponent : null}
</div>
);
Expand Down