Skip to content

RSC webpack 5 plugin #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

RSC webpack 5 plugin #52

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
841f2ff
add webpack 5 and ts
michenly Oct 5, 2021
73187c1
get ts passing
michenly Oct 5, 2021
620df50
fix html-webpack-plugin with different version of webpack
michenly Oct 6, 2021
ac0d27d
remove webpack 4
michenly Oct 6, 2021
6a96c5e
resolved webpack deprecation warming
michenly Oct 6, 2021
4a2ed3e
update usage of getProvidedExports
michenly Oct 6, 2021
3271db4
add jsx
michenly Oct 6, 2021
f61d52b
add type for resource
michenly Oct 7, 2021
0de5d4c
add warning if client runtime was not found
michenly Oct 18, 2021
63bb688
commit old build files for comparision
michenly Oct 20, 2021
159f78b
get it running without error
michenly Oct 20, 2021
daddb6e
update webpack version
michenly Oct 29, 2021
959285b
change to use parser.hook instead of buildModule to modify module
michenly Nov 8, 2021
7aa5269
fix react-client-manifest id field output
michenly Nov 8, 2021
9fd4141
remove un-use type
michenly Nov 8, 2021
b0dc031
move run to beforeCompile hook and use the current contextModuleFactory
michenly Nov 8, 2021
2efefbd
remove hack that replace undefined
michenly Nov 10, 2021
9c356fb
stylistic updates
michenly Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stylistic updates
  • Loading branch information
@michenly
michenly committed Nov 10, 2021
commit 9c356fb62c5e50e01885fe68d3f58871867e1c09
29 changes: 14 additions & 15 deletions plugins/react-server-dom-webpack-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
'use strict';

import path from 'path';
import url from 'url';
import {pathToFileURL} from 'url';
import asyncLib from 'neo-async';
import ModuleDependency from 'webpack/lib/dependencies/ModuleDependency';
import NullDependency from 'webpack/lib/dependencies/NullDependency';
Expand Down Expand Up @@ -126,7 +126,6 @@ export default class ReactFlightWebpackPlugin {
}
);
});


compiler.hooks.thisCompilation.tap(PLUGIN_NAME, function(compilation: Compilation, {normalModuleFactory}) {
compilation.dependencyFactories.set(
Expand Down Expand Up @@ -204,9 +203,9 @@ export default class ReactFlightWebpackPlugin {
return;
}

var json = {};
const json = {};
compilation.chunkGroups.forEach(function(chunkGroup) {
var chunkIds = chunkGroup.chunks.map(function(c) {
const chunkIds = chunkGroup.chunks.map(function(c) {
return c.id;
});

Expand All @@ -223,7 +222,7 @@ export default class ReactFlightWebpackPlugin {
.getExportsInfo(module)
.getProvidedExports();

var moduleExports = {};
const moduleExports = {};
['', '*']
.concat(Array.isArray(moduleProvidedExports) ? moduleProvidedExports : [])
.forEach(function(name) {
Expand All @@ -233,7 +232,7 @@ export default class ReactFlightWebpackPlugin {
name: name,
};
});
var href = url.pathToFileURL((module as ModuleWithResource).resource).href;
const href = pathToFileURL((module as ModuleWithResource).resource).href;

if (href !== undefined) {
json[href] = moduleExports;
Expand All @@ -242,7 +241,7 @@ export default class ReactFlightWebpackPlugin {

chunkGroup.chunks.forEach(function(chunk) {
const chunkModules = compilation.chunkGraph.getChunkModulesIterable(chunk)
for (const module of chunkModules) {
for (let module of chunkModules) {

const moduleId = compilation.chunkGraph.getModuleId(module);

Expand Down Expand Up @@ -285,15 +284,15 @@ export default class ReactFlightWebpackPlugin {
return;
}

var clientReferenceSearch = clientReferencePath;
const clientReferenceSearch = clientReferencePath;
contextResolver.resolve(
{},
context,
clientReferencePath.directory,
{},
function(err, resolvedDirectory) {
if (err) return cb(err);
var options = {
const options = {
resource: resolvedDirectory,
resourceQuery: '',
recursive:
Expand All @@ -309,10 +308,10 @@ export default class ReactFlightWebpackPlugin {
deps
) {
if (err2) return cb(err2);
var clientRefDeps = deps.map(function(dep) {
// use userRequest instead of request. request always end with undefined
var request = path.join(resolvedDirectory, dep.userRequest);
var clientRefDep = new ClientReferenceDependency(request);
const clientRefDeps = deps.map(function(dep) {
// use userRequest instead of request. request always end with undefined which is wrong
const request = path.join(resolvedDirectory, dep.userRequest);
const clientRefDep = new ClientReferenceDependency(request);
clientRefDep.userRequest = dep.userRequest;
return clientRefDep;
});
Expand All @@ -323,9 +322,9 @@ export default class ReactFlightWebpackPlugin {
},
function(err, result) {
if (err) return callback(err);
var flat = [];
const flat = [];

for (var i = 0; i < result.length; i++) {
for (let i = 0; i < result.length; i++) {
flat.push.apply(flat, result[i]);
}

Expand Down