fix: removing our dependency on trim
#1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
approved these changes
Nov 4, 2024
rafegoldberg
pushed a commit
that referenced
this pull request
Nov 7, 2024
## Version 7.10.0 ### ✨ New & Improved * columns ([#1008](#1008)) ([1a3625a](1a3625a)) ### 🛠 Fixes & Updates * **deps:** bump @mdx-js/mdx from 3.0.1 to 3.1.0 ([#1023](#1023)) ([cf28a98](cf28a98)) * **deps:** bump @readme/emojis from 5.1.0 to 6.0.0 ([#1025](#1025)) ([9feeb50](9feeb50)), closes [readmeio/emojis#85](readmeio/emojis#85) [#85](#85) * **deps:** bump core-js from 3.38.1 to 3.39.0 ([#1027](#1027)) ([3963833](3963833)), closes [/github.com/tc39/proposal-iterator-helpers/issues/284#event-14549961807](https://github.com/readmeio//github.com/tc39/proposal-iterator-helpers/issues/284/issues/event-14549961807) * **deps:** bump debug from 4.3.4 to 4.3.7 ([#1022](#1022)) ([8830a5d](8830a5d)), closes [debug-js/debug#819](debug-js/debug#819) [debug-js/debug#969](debug-js/debug#969) [debug-js/debug#969](debug-js/debug#969) [#926](#926) [#819](#819) [#926](#926) * **deps:** bump emoji-regex from 10.3.0 to 10.4.0 ([#1020](#1020)) ([8b4e8c7](8b4e8c7)), closes [#113](#113) * **deps:** bump estree-util-value-to-estree from 3.1.1 to 3.2.1 ([#1026](#1026)) ([19f2ff4](19f2ff4)) * **deps:** bump hast-util-from-html from 2.0.1 to 2.0.3 ([#1028](#1028)) ([97a7ae7](97a7ae7)) * **deps:** bump remark-mdx from 3.0.1 to 3.1.0 ([#1021](#1021)) ([0b3b087](0b3b087)) * removing our dependency on `trim` ([#1029](#1029)) ([656187d](656187d)) <!--SKIP CI-->
Contributor
|
This PR was released!🚀 Changes included in v7.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Installing the markdown package throws these warnings from NPM for the
trimpackage:It seems that we're no longer using
trimanymore(?) so I'm removing it from being a dependency.Before
After
🧬 QA & Testing
All tests were still passing and the dist still gets built fine with
npm run build.