Skip to content

fix(compat mode): don't inject inline scripts on server #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020
Merged

fix(compat mode): don't inject inline scripts on server #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(compat mode): don't inject inline scripts on server
  • Loading branch information
@rafegoldberg
rafegoldberg committed Aug 11, 2020
commit b98a1e8f6ed71a9231e9b481e2c8d2861cfeeca3
3 changes: 3 additions & 0 deletions components/HTMLBlock.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,11 @@ const PropTypes = require('prop-types');
* @arg {string} html the HTML from which to extract script tags.
*/
const extractScripts = html => {
if (typeof window === 'undefined' || !html) return () => {};

const regex = /<script\b[^>]*>([\s\S]*?)<\/script>/gim;
const scripts = [...html.matchAll(regex)].map(m => m[1].trim());

return () => scripts.map(js => window.eval(js));
};

Expand Down