Skip to content

feat: async run #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2024
Merged

feat: async run #858

merged 2 commits into from
Apr 10, 2024

Conversation

@kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented Apr 10, 2024 •
edited
Loading

PR App

🧰 Changes

Changes rmdx.run to be async.

I think use mdx.runSync means you can't call import?!

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta April 10, 2024 21:16
@kellyjosephprice kellyjosephprice marked this pull request as ready for review April 10, 2024 22:07
jennspencer
jennspencer approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@jennspencer jennspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏃🏻‍♂️

@kellyjosephprice kellyjosephprice merged commit 61a3e19 into beta Apr 10, 2024
@kellyjosephprice kellyjosephprice deleted the feat/async-run branch April 10, 2024 22:25
rafegoldberg pushed a commit that referenced this pull request Apr 10, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.24 🦉
a7b6b6c 
## Version 6.75.0-beta.24

### ✨ New & Improved

* async run ([#858](#858)) ([61a3e19](61a3e19))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

rafegoldberg commented Apr 10, 2024

This PR was released!

🚀 Changes included in v6.75.0-beta.24

@kellyjosephprice kellyjosephprice mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dashron Dashron Awaiting requested review from Dashron

1 more reviewer

@jennspencer jennspencer jennspencer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kellyjosephprice @rafegoldberg @jennspencer