Skip to content

fix: types #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 17, 2024
Merged

fix: types #877

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db54845
chore: type readme-components
kellyjosephprice May 17, 2024
b60fb77
oops
kellyjosephprice May 17, 2024
7de8307
use src
kellyjosephprice May 17, 2024
24c5734
comment
kellyjosephprice May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use src
  • Loading branch information
@kellyjosephprice
kellyjosephprice committed May 17, 2024
commit 7de8307e9cb41559b073c5a38ddf4c9486b45f86
2 changes: 1 addition & 1 deletion __tests__/transformers/readme-components.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Second
},
image: {
md: `![](http://placekitten.com/600/200)`,
mdx: `<Image url="http://placekitten.com/600/200" />`,
mdx: `<Image src="http://placekitten.com/600/200" />`,
},
table: {
md: `
Expand Down
4 changes: 2 additions & 2 deletions processor/transform/readme-components.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,14 @@ const coerceJsxToMd =
parent.children[index] = mdNode;
} else if (node.name === 'Image') {
const { position } = node;
const { alt = '', url, title = null } = attributes<Pick<Image, 'alt' | 'url' | 'title'>>(node);
const { alt = '', src, title = null } = attributes<Pick<Image, 'alt' | 'title'> & { src: string }>(node);

const mdNode: Image = {
alt,
position,
title,
type: 'image',
url,
url: src,
};

parent.children[index] = mdNode;
Expand Down