Skip to content

fix: callouts #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 22, 2024
Merged

fix: callouts #880

merged 8 commits into from
May 22, 2024

Conversation

@kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented May 21, 2024 •
edited
Loading

PR App Fix RM-9785

🧰 Changes

Fixes callouts?!

Apparently some previous work horribly munged callouts. Oops

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta May 21, 2024 18:12
@kellyjosephprice kellyjosephprice changed the title fix: widgets fix: callouts May 21, 2024
@kellyjosephprice kellyjosephprice marked this pull request as ready for review May 22, 2024 16:50
@kellyjosephprice
Copy link
Collaborator Author

kellyjosephprice commented May 22, 2024

The failing test is the embed snapshot test. It appears to get to a different loading state each time.

jennspencer
jennspencer approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@jennspencer jennspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.> 🚀 LGTM

@kellyjosephprice kellyjosephprice merged commit cf7e284 into beta May 22, 2024
@kellyjosephprice kellyjosephprice deleted the fix/widgets branch May 22, 2024 19:28
rafegoldberg pushed a commit that referenced this pull request May 22, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.35 🦉
79fd386 
## Version 6.75.0-beta.35

### 🛠 Fixes & Updates

* callouts ([#880](#880)) ([cf7e284](cf7e284))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

rafegoldberg commented May 22, 2024

This PR was released!

🚀 Changes included in v6.75.0-beta.35

@kellyjosephprice kellyjosephprice mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trishaprile trishaprile Awaiting requested review from trishaprile

1 more reviewer

@jennspencer jennspencer jennspencer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kellyjosephprice @rafegoldberg @jennspencer