feat: compatibility #881
Merged
feat: compatibility #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennspencer
reviewed
May 23, 2024
processor/compile/compatability.ts
Outdated
| } | ||
| }; | ||
|
|
||
| export default compatability; |
Contributor
There was a problem hiding this comment.
😬 😬 😬 how do i break it to you that you spelled compatibility wrong 😬
Collaborator
Author
There was a problem hiding this comment.
If spelling compatability like compat-ability is wrong, I don't want to be right.
Contributor
|
This PR was released!🚀 Changes included in v6.75.0-beta.38 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Adds backwards compatibility with variables, glossary, and reusable content.
When we're trying to update a document from markdown to MDX, we first parse the document to an mdast using the old markdown library. Then we serialize it back to MDX with this version. Basically:
But, because these types are now completely represented in JSX, we didn't have any custom compilers to handle them. This adds some compilers to write their nodes back out as JSX.
Callouts
Also, refactors how callouts are represented. Adds a prop to the node
emptyto represent if there's a heading a not. It's a bit more plumbing to get mdx to parse and execute props, so this leaves the heading as a child.HTML Comments
To be able to migrate away, we need to replace html comments with JSX comments.
🧬 QA & Testing