Skip to content

Conversation

@kellyjosephprice
Copy link
Collaborator

PR App Fix RM-9861

🧰 Changes

I changed the name of GlossaryItem to Glossary, but we never load @readme/mdx's css in the main app. This caused the glossary tooltip to be unstyled.

I poked at getting rmdx's styles loaded, but ran into some issues with codemirror. So for now, I'm relying on the old styling to still be available, blheh.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta May 29, 2024 19:15
@kellyjosephprice kellyjosephprice marked this pull request as ready for review May 29, 2024 19:59
Copy link
Contributor

@jennspencer jennspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@kellyjosephprice kellyjosephprice merged commit 4ec815f into beta May 29, 2024
@kellyjosephprice kellyjosephprice deleted the beta-styling branch May 29, 2024 21:48
rafegoldberg pushed a commit that referenced this pull request May 29, 2024
## Version 6.75.0-beta.44

### ✨ New & Improved

* fix glossary item ([#890](#890)) ([4ec815f](4ec815f))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.0-beta.44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants