feat: jsx variables #899
Merged
feat: jsx variables #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyjosephprice
requested review from
jennspencer,
rafegoldberg and
trishaprile
Contributor
There was a problem hiding this comment.
Code looks good and it's working nicely locally; would approve save for one concern.
processor/transform/index.ts
Outdated
| export { readmeComponentsTransformer, readmeToMdx, injectComponents, variables }; | ||
|
|
||
| export default [calloutTransformer, codeTabsTransfromer, embedTransformer, gemojiTransformer]; | ||
| export default [calloutTransformer, codeTabsTransfromer, embedTransformer, gemojiTransformer, variables]; |
Contributor
There was a problem hiding this comment.
Shouldn't this export be called variablesTransformer if only for consistency?
docs/variable-tests.md
Outdated
Comment on lines
11
to
15
| It does not render in code blocks: | ||
|
|
||
| ```js | ||
| const xyz = "<Variable variable="defvar" />"; | ||
| ``` | ||
| {user.defvar} | ||
| ``` |
Contributor
There was a problem hiding this comment.
I think these vars need to be usable within code blocks; I've seen customers use this functionality to construct customized copyable snippets! (It used to be that you'd escape them– something like \<<defvar\>> –if you wanted to show the string literally.)
jennspencer
reviewed
Jun 12, 2024
Collaborator
Author
|
@rafegoldberg approve me? |
Contributor
|
This PR was released!🚀 Changes included in v6.75.0-beta.57 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Uses jsx variables for user variables.
The first pass at variables was very simple:
This replaces with regular old jsx interpolated variables:
Much nicer!
🧬 QA & Testing