Skip to content

fix: decode HTML outside of component render #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 14, 2024
Merged

fix: decode HTML outside of component render #905

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
30693a7
decode HTML before render
jennspencer Jun 14, 2024
958a810
check if not encoded
jennspencer Jun 14, 2024
25831e5
error checks
jennspencer Jun 14, 2024
38b8a12
typo
jennspencer Jun 14, 2024
2ba9b1c
oops
jennspencer Jun 14, 2024
6f942a5
fix
jennspencer Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
decode HTML before render
  • Loading branch information
@jennspencer
jennspencer committed Jun 14, 2024
commit 30693a7a172e5296e169aadb646f59901fa15e7e
3 changes: 2 additions & 1 deletion components/Embed/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const Embed = ({
}: EmbedProps) => {
if (typeof iframe !== 'boolean') iframe = iframe === 'true';
if (html === 'false') html = undefined;
if (html) html = decodeURIComponent(html);

if (iframe) {
return <iframe {...attrs} src={url} style={{ border: 'none', display: 'flex', margin: 'auto' }} />;
Expand All @@ -54,7 +55,7 @@ const Embed = ({
return (
<div className={classes.join(' ')}>
{html ? (
<div className="embed-media" dangerouslySetInnerHTML={{ __html: decodeURIComponent(html) }} />
<div className="embed-media" dangerouslySetInnerHTML={{ __html: html }} />
) : (
<a className="embed-link" href={url} rel="noopener noreferrer" target="_blank">
{!image || <img alt={title} className="embed-img" loading={lazy ? 'lazy' : undefined} src={image} />}
Expand Down