feat: new <Cards> component #908
Merged
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/run.tsx
Outdated
| 'embed-block': Components.Embed, | ||
| 'image-block': Components.Image, | ||
| 'table-of-contents': Components.TableOfContents, | ||
| 'cards-grid': Components.CardsGrid, |
Collaborator
There was a problem hiding this comment.
I think you don't need this line. I actually think the preceding 3 or 4 are unnecessary too, but I can follow up on that. These are the tag names, so CardsGrid should already be getting pulled in here:
Line 35 in c683a80
This has me wondering if overwriting, for instance, the img tag is a good idea. This makes it impossible for someone to use them in a custom component without our component:
const CustomImage = (props) => {
return <img {...props} />
}
Contributor
Author
There was a problem hiding this comment.
just linking the related ticket (RM-10076) here for posterity
see https://react.dev/reference/react/Children Co-authored-by: Kelly Joseph Price <[email protected]>
trishaprile
approved these changes
Jun 19, 2024
Member
trishaprile
left a comment
trishaprile
left a comment
There was a problem hiding this comment.
merging this in but happy to keep updating this if needed !
Contributor
Author
|
This PR was released!🚀 Changes included in v6.75.0-beta.59 |
Closed
rafegoldberg
pushed a commit
that referenced
this pull request
Jan 8, 2025
## Version 7.11.0 ### ✨ New & Improved * add title props to plain ([#1036](#1036)) ([a3b7f50](a3b7f50)) ### 🛠 Fixes & Updates * **deps:** bump debug from 4.3.7 to 4.4.0 ([#1038](#1038)) ([a5a8061](a5a8061)) * **deps:** bump readmeio/rdme from 8 to 9 ([#1037](#1037)) ([3f403de](3f403de)), closes [/github.com/readmeio/rdme/blob/HEAD/#migrating-to-rdme10](https://github.com/readmeio//github.com/readmeio/rdme/blob/HEAD//issues/migrating-to-rdme10) [#1099](#1099) [#1085](#1085) [#1106](#1106) [#1107](#1107) [#1068](#1068) [#962](#962) [#1067](#1067) [github.com/readmeio/rdme/blob/d01d76fe3c2e4a98b4f5c415be03e589fbe3b56e/.releaserc.yml#L30](https://github.com/readmeio/github.com/readmeio/rdme/blob/d01d76fe3c2e4a98b4f5c415be03e589fbe3b56e/.releaserc.yml/issues/L30) [#1067](#1067) [#1072](#1072) [#1100](#1100) [#1078](#1078) [#1042](#1042) [#908](#908) [#901](#901) [#1073](#1073) [#1080](#1080) [#961](#961) [#963](#963) [#993](#993) [github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md#2023-11-22-version-20100](https://github.com/readmeio/github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V20.md/issues/2023-11-22-version-20100) [#965](#965) [#1080](#1080) [#1106](#1106) [#1105](#1105) [#1098](#1098) [#1099](#1099) [#1100](#1100) * dont treat escapes as flow ([#1040](#1040)) ([4692ece](4692ece)) <!--SKIP CI-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
<Cards>component