fix: compatibility for unknown nodes #929
Conversation
| .use(hast ? rehypeRemark : undefined) | ||
| .use(remarkMdx) | ||
| .use(remarkGfm) | ||
| .use(divTransformer) |
There was a problem hiding this comment.
i'm not 100% on this placement, whether or not it should be before the hastifying
There was a problem hiding this comment.
This is fine, I don't think there's any hastifing in this function. It's taking either an mdast or a hast and outputting mdx.
|
this will cause some of the pages with i'm assuming that's because custom components aren't being sent in the migration script--easy enough to fix |
Yea, it's defined in the main app. We should probably add a stub to the migration so we don't got those errors. |
kellyjosephprice
left a comment
kellyjosephprice
left a comment
There was a problem hiding this comment.
Seems reasonable to me.
Thanks for cleaning up all the cruft!
| type: NodeTypes.tutorialTile, | ||
| } as TutorialTile; | ||
| parent.children.splice(index, 1, tile); | ||
| // idk what this is and/or just make it a paragraph |
|
This PR was released!🚀 Changes included in v6.75.0-beta.70 |
🧰 Changes
Unhandled nodes are throwing errors during migration. Offending node types:
divembedfigureirdme-pinyaml🧬 QA & Testing
You can look up the
Cannot handle unknown node <node>errors from Aaron's migration spreadsheet to find pages to test locally, if you want to usemake mdxto swap out the dist files in yourreadmerepo.You'll have to check out his other PR with the migration scripts first, which has directions for testing pages.