Skip to content

fix(beta): toc generation when using MDX components #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix(beta): toc generation when using MDX components #933

merged 1 commit into from
Jul 3, 2024

Conversation

@rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Jul 3, 2024 •
edited
Loading

💬 Thread
  • optionally chain the TOC regex matcher

@rafegoldberg rafegoldberg added bug Something isn't working refactor Issues about tackling technical debt labels Jul 3, 2024
@rafegoldberg rafegoldberg requested review from a team, jennspencer and kellyjosephprice July 3, 2024 18:09
@rafegoldberg rafegoldberg marked this pull request as ready for review July 3, 2024 18:10
@rafegoldberg rafegoldberg merged commit c1408e3 into beta Jul 3, 2024
@rafegoldberg rafegoldberg deleted the fix/beta/toc-error-with-components branch July 3, 2024 18:11
jennspencer
jennspencer reviewed Jul 3, 2024
View reviewed changes
@rafegoldberg rafegoldberg mentioned this pull request Jul 3, 2024
Merged
1 task
rafegoldberg pushed a commit that referenced this pull request Jul 3, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.68 🦉
4eed398 
## Version 6.75.0-beta.68

### 🛠 Fixes & Updates

* **beta:** toc generation when using MDX components ([#933](#933)) ([c1408e3](c1408e3))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor Author

rafegoldberg commented Jul 3, 2024

This PR was released!

🚀 Changes included in v6.75.0-beta.68

rafegoldberg added a commit that referenced this pull request Jul 3, 2024
@rafegoldberg
chore(beta): nix errant log (#934)
04b55eb 
- [x] nix errant `console.log` per @jennspencer [on
#933](#933 (comment))
rafegoldberg pushed a commit that referenced this pull request Jul 3, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.69 🦉
d44dcd9 
## Version 6.75.0-beta.69

### ✨ New & Improved

* force release ([d3e4da3](d3e4da3))

### 🛠 Fixes & Updates

* **beta:** nix errant log ([#934](#934)) ([04b55eb](04b55eb)), closes [#933](#933) [/github.com//pull/933#discussion_r1664579308](https://github.com/readmeio//github.com/readmeio/markdown/pull/933/issues/discussion_r1664579308)

<!--SKIP CI-->
@kellyjosephprice kellyjosephprice mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

+1 more reviewer

@jennspencer jennspencer jennspencer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working refactor Issues about tackling technical debt released on @beta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rafegoldberg @kellyjosephprice @jennspencer