Skip to content

feat: stringify object values #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2021
Merged

feat: stringify object values #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions __tests__/index.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ describe('single variable', () => {
});

it.todo('should set `selected` if nothing is selected');

it('should render objects as strings', () => {
const variable = shallow(<Variable {...props} user={{ apiKey: { renderTo: 'string' } }} />);

expect(variable.text()).toBe(JSON.stringify({ renderTo: 'string' }));
});
});

describe('multiple variables', () => {
Expand Down
4 changes: 2 additions & 2 deletions index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ class Variable extends React.Component {
// - uppercase key
getValue() {
const { variable } = this.props;
if (this.props.user[variable]) return this.props.user[variable];
const value = this.props.user[variable] || this.getDefault();

return this.getDefault();
return typeof value === 'object' ? JSON.stringify(value) : value;
}

toggleVarDropdown() {
Expand Down