-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Cython description and code example added #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/scenarios/speed.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your indentation here is incorrect. The first line needs to be indented by 4 and the function body needs to be dedented by 4.
You are right, i will do it. Thank you for the tip! |
@tommy3001 please do not open a new Pull Request. If you continue to make changes and push them to your fork, this Pull Request will update and we can continue the discussion in one place. |
Fixed |
docs/scenarios/speed.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same indentation fixes here as above please.
@tommy3001 you're almost there. Thanks for this! It looks like it will be an awesome contribution! 🍰 |
Ok, right. Thank you for your patience. I will commit machine competition in future. :) |
You missed one last block of indentation necessary. I haven't read the copy closely, so there may be future changes necessary but if they're minor I might just merge this and handle them myself. |
Big sorry, I made some copy/paste misstakes from my code/ide source. I added an additional benchmark. ;-) |
No need to apologize. Noone is upset. =) |
nice addition tommy |
You start most of your sentences with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`Cython <http://cython.org/>`_ implements a superset of the Python language with which you are able to write C and C++ modules for Python. Cython also allows you to call functions from compiled C libraries. Using Cython allows you to take advantage of Python's strong typing of variables and operations. Here is an example of strong typing with Cython:
As a side note, I hope you realize that static typing is not strong typing. C is inherently weakly typed and Python strongly typed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed this one too it seems
docs/scenarios/speed.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch commands
for keywords
.
Done. Thank you for your support. |
Thanks! |
Cython description and code example added
I think that is possibly a next stone for our church.