replace stereo module with depth module#2688
Merged
Nir-Az merged 1 commit intorealsenseai:ros2-developmentfrom Apr 12, 2023
Merged
replace stereo module with depth module#2688Nir-Az merged 1 commit intorealsenseai:ros2-developmentfrom
Nir-Az merged 1 commit intorealsenseai:ros2-developmentfrom
Conversation
Nir-Az
approved these changes
Apr 12, 2023
Collaborator
Nir-Az
left a comment
There was a problem hiding this comment.
LGTM
@SamerKhshiboun need to notify Val team?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by [DSO-18538]
Replace Info and Debug output including "Stereo Module" with "Depth Module"
Used "rs2_to_ros" function, which is in a common use inside our ROS wrapper, but was missing in some other places.
For example:
with new change, service sensor output includes depth_module instead of stereo_module
also when launching / stopping the node, new changes are on (depth module instead of stereo module):
also when running with log_level:=debug, the changes are on (depth module instead of stereo module)